PubMatic Bid Adapter : send viewability percentage of slots #13092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
patmmccann
reviewed
May 13, 2025
patmmccann
reviewed
May 13, 2025
patmmccann
reviewed
May 13, 2025
patmmccann
reviewed
May 13, 2025
| } | ||
|
|
||
| // Add viewability data at the imp.ext level | ||
| imp.ext.viewability = { |
There was a problem hiding this comment.
why not put it on metrics where it belongs?
There was a problem hiding this comment.
nevermind, putting it on metrics feels wrong, as that is for aggregate viewability, not viewability of the square at time of request... hmm, maybe we could propose a new metric?
There was a problem hiding this comment.
Here, we're calculating viewability on a per-slot basis, so instead of creating the metric at the impression level, we’ve included it in the ext object.
|
Tread carefully! This PR adds 3 linter warnings (possibly disabled through directives):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Enhance the PubMatic bid adapter to measure and report ad viewability for both banner and video impressions using the percentInView utility.