Core: Remove getStatusCode and statusMessage from bid object #13086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For the 12895 breaking changes / API cleanup, covered - remove bids' getStatusCode and statusMessage fields
The getStatusCode method consistently returns 1, and statusMessage is always 'Bid available', making both redundant. This change removes getStatusCode() and statusMessage from the Bid object. Consequently, the Bid() constructor and createBid() method in bidfactory no longer accept statusCode as a parameter.
Please go through your respective modules and accommodate these changes accordingly. For now, a constant fallback has been applied to ensure backward compatibility and prevent any runtime issues.
Other information
12895
Tagging maintainers :
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]