Skip to content

Luponmedia Bid Adapter: improve fallback bid alignment and dynamic server resolution #13020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

milosandrejic
Copy link

@milosandrejic milosandrejic commented Apr 22, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

milosandrejic and others added 29 commits March 3, 2025 12:45
@osazos
Copy link
Collaborator

osazos commented May 6, 2025

@ChrisHuie @patmmccann, I’d like your input on the behavior introduced in this PR. It involves custom logic to reuse cached bids during interpretResponse, and I’m not sure whether that’s allowed.

@milosandrejic
Copy link
Author

Thank you for the feedback.

We understand that any form of bid reuse outside the same auction, or storage outside of Prebid.js core mechanisms, is not compliant with module guidelines.

We've updated the PR to remove all localStorage-based functionality and ensure full compliance.
Please have another look when you have a moment.

@ChrisHuie ChrisHuie self-requested a review May 21, 2025 12:14
@ChrisHuie ChrisHuie self-assigned this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants