OneId System : initial release #12979
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlquaccia
reviewed
May 7, 2025
| * @param {SubmoduleConfig} [config] | ||
| * @returns {IdResponse|undefined} | ||
| */ | ||
| getId(config) { |
There was a problem hiding this comment.
do you need to provide any validations against user consentData?
There was a problem hiding this comment.
SDK itself doing that check, so it seems redundant. But in case prebid policy require that, I can add it. Seems like nothing bad happens in case we check it twice
There was a problem hiding this comment.
That makes sense. If you guys already have something in place, sounds like you are already good there then.
Looks like there is a test failing within the circleci e2e test.. otherwise, everything else LGTM!
|
@Akiyamka left one comment. Also noticed that one circle ci test is failing |
jlquaccia
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
New Id system module for OneId
Contact email of maintainer: [email protected]
Other information