T-Embed CC1101 RGB LEDs go out when the screen is turned off #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont want to ask to much... But is it possible to make a switch so its
possible to choose between having light on supreme modus and off... As i
would like to have booth options as it can be a pain sometimes to have
light on, when screen is turned off... BUT it can also be alot of fun when
your in ninja modus and your using the light to light up a room and or
other devices so u can see magic in the dark... It all depends on the
mood... (And if your having a sweet lady with you or not... :o )
…On Sat, Aug 23, 2025 at 6:12 PM TheMiner203 ***@***.***> wrote:
Previously, when the screen was turned off, the standby mode remained on,
which increased power consumption and looked strange. The LEDs now turn off
when the screen is turned off, and turn on when it is turned on. Tested on
T-Embed CC1101. There are bugs, for example, the preview of effects does
not work well, but it's better than nothing.
------------------------------
You can view, comment on, or merge this pull request online at:
#1576
Commit Summary
- a872cab
<a872cab>
added setLedState for turning RGB LEDs off
- 60d223a
<60d223a>
added setLedState for turning RGB LEDs on
- 80af026
<80af026>
added setLedState for controlling RGB
- 43ddc7c
<43ddc7c>
added setLedState for controlling RGB
File Changes
(4 files <https://github.com/pr3y/Bruce/pull/1576/files>)
- *M* src/core/display.cpp
<https://github.com/pr3y/Bruce/pull/1576/files#diff-d838bb53dd12aacfabb4a664f15adda5a1c9be9244ea162c5b643b5751cf1e4e>
(2)
- *M* src/core/led_control.cpp
<https://github.com/pr3y/Bruce/pull/1576/files#diff-7f767e231ef69b11527e9a9ab1abf1f7cb2074d368a3a1ef6ecf208ed58b458b>
(11)
- *M* src/core/led_control.h
<https://github.com/pr3y/Bruce/pull/1576/files#diff-b58fa2d605201d0d0521eb52b44179e4c5b319e1562f8679bf4966b915b99943>
(1)
- *M* src/core/powerSave.cpp
<https://github.com/pr3y/Bruce/pull/1576/files#diff-5ce2bb631f2d749c32f0bfd459fb4b76b7f84986c341f792a991a10e4b828643>
(6)
Patch Links:
- https://github.com/pr3y/Bruce/pull/1576.patch
- https://github.com/pr3y/Bruce/pull/1576.diff
—
Reply to this email directly, view it on GitHub
<#1576>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLDL6BQXC4TSPYJ3QWXWF533PCHFXAVCNFSM6AAAAACEUJAD6WVHI2DSMVQWIX3LMV43ASLTON2WKOZTGM2DQNBSHE4DQMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Kind Regards
C.R
May Prosperity allways be with us!!
|
|
Also what does the led blink do ? As i turned it off and on , on my t embed
cc1101 and i never seen any blinking... My pets be like... ?? Even Sharky
asked me about it...
On Sat, Aug 23, 2025 at 6:20 PM Christian Roth. ***@***.***>
wrote:
… I dont want to ask to much... But is it possible to make a switch so its
possible to choose between having light on supreme modus and off... As i
would like to have booth options as it can be a pain sometimes to have
light on, when screen is turned off... BUT it can also be alot of fun when
your in ninja modus and your using the light to light up a room and or
other devices so u can see magic in the dark... It all depends on the
mood... (And if your having a sweet lady with you or not... :o )
On Sat, Aug 23, 2025 at 6:12 PM TheMiner203 ***@***.***>
wrote:
> Previously, when the screen was turned off, the standby mode remained on,
> which increased power consumption and looked strange. The LEDs now turn off
> when the screen is turned off, and turn on when it is turned on. Tested on
> T-Embed CC1101. There are bugs, for example, the preview of effects does
> not work well, but it's better than nothing.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #1576
> Commit Summary
>
> - a872cab
> <a872cab>
> added setLedState for turning RGB LEDs off
> - 60d223a
> <60d223a>
> added setLedState for turning RGB LEDs on
> - 80af026
> <80af026>
> added setLedState for controlling RGB
> - 43ddc7c
> <43ddc7c>
> added setLedState for controlling RGB
>
> File Changes
>
> (4 files <https://github.com/pr3y/Bruce/pull/1576/files>)
>
> - *M* src/core/display.cpp
> <https://github.com/pr3y/Bruce/pull/1576/files#diff-d838bb53dd12aacfabb4a664f15adda5a1c9be9244ea162c5b643b5751cf1e4e>
> (2)
> - *M* src/core/led_control.cpp
> <https://github.com/pr3y/Bruce/pull/1576/files#diff-7f767e231ef69b11527e9a9ab1abf1f7cb2074d368a3a1ef6ecf208ed58b458b>
> (11)
> - *M* src/core/led_control.h
> <https://github.com/pr3y/Bruce/pull/1576/files#diff-b58fa2d605201d0d0521eb52b44179e4c5b319e1562f8679bf4966b915b99943>
> (1)
> - *M* src/core/powerSave.cpp
> <https://github.com/pr3y/Bruce/pull/1576/files#diff-5ce2bb631f2d749c32f0bfd459fb4b76b7f84986c341f792a991a10e4b828643>
> (6)
>
> Patch Links:
>
> - https://github.com/pr3y/Bruce/pull/1576.patch
> - https://github.com/pr3y/Bruce/pull/1576.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#1576>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BLDL6BQXC4TSPYJ3QWXWF533PCHFXAVCNFSM6AAAAACEUJAD6WVHI2DSMVQWIX3LMV43ASLTON2WKOZTGM2DQNBSHE4DQMI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
Kind Regards
C.R
May Prosperity allways be with us!!
--
Kind Regards
C.R
May Prosperity allways be with us!!
|
|
This clashes with an already open pull request which I believe does very similar. |
The LED will blink when the RF scan is running and something is detected. |
Yes, I checked, and it works much better than mine. Closing the pull request. |
|
Thanks for letting me know.. I just tried it and it worked like a charm..
Still blinking , this is top shelf style.. I want even more if its
possible of this kind of stuff.... Pimp my ride...
…On Sun, Aug 24, 2025 at 6:42 AM TheMiner203 ***@***.***> wrote:
*TheMiner203* left a comment (pr3y/Bruce#1576)
<#1576 (comment)>
This clashes with an already open pull request which I believe does very
similar.
#1487 <#1487>
Yes, I checked, and it works much better than mine. Closing the pull
request.
—
Reply to this email directly, view it on GitHub
<#1576 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLDL6BWL35GRP5JJ3A6TDDT3PE7DFAVCNFSM6AAAAACEUJAD6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJXG43TGMJYGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Kind Regards
C.R
May Prosperity allways be with us!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the screen was turned off, the standby mode remained on, which increased power consumption and looked strange. The LEDs now turn off when the screen is turned off, and turn on when it is turned on. Tested on T-Embed CC1101. There are bugs, for example, the preview of effects does not work well, but it's better than nothing.