-
-
Notifications
You must be signed in to change notification settings - Fork 950
CYD devices fix #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CYD devices fix #1551
Conversation
add 1 3 35 pin to ir tx add 1 3 pin to ir rx add speaker support for cyd-2423s028 (and cyd-2usb) on 26pin and removed inverted color by default
what are the build errors are you facing? it is better you build and test, as you know your hardware, and let us know the results... |
I have this build error : In file included from src/core/display.h:25, In file included from src/core/display.cpp:1586: In file included from src/core/display.h:25, Compiling .pio\build\CYD-2432S028\src\core\led_control.cpp.o
#include <FastLED.h>
#include <FastLED.h> Environment Status Duration CYD-2432S028 FAILED 00:01:07.438
|
Sync your repo to mainstream, and pull the last code version to fix this issue
You enabled the LED interface for this device, so you need to add the library in this file line Bruce/boards/CYD-2432S028/CYD-2432S028.ini Line 163 in 7480f2e Make it like this
Before compile, delete the whole .pio folder inside the project, to make sure it downloads the latest version of the libraries |
can you just enable speaker on pin 26 and remove color inversion for cyds? |
Color inversion you can set on Config>Ui Color> Inverted Color I will try to test this speaker thing, not sure if it will work |
|
Proposed Changes
i added speaker support for a CYD-2432s028r and CYD-2USB and removed inverted color by default and added pin 1, 3 and 35 for IR TX and pin 1, 3 for IR RX
Types of Changes
Verification
Testing
I tried to check cyd-2432s028r but my project doesn't compile
Linked Issues
#1546 #1438
User-Facing Change
NONEFurther Comments
Sorry I couldn't check because of a build error
let someone check this change and write that it works