Skip to content
This repository was archived by the owner on Nov 6, 2024. It is now read-only.

Initial import from pq-crystals/kyber/ref @ 11d00ff1 #1

Closed
wants to merge 1 commit into from

Conversation

jschanck
Copy link

This is a straight copy of the ref/ subdirectory from pq-crystals/kyber @ 11d00ff1.

Is this what we want?

Some initial thoughts.

  • We may want to move test/ and nistkat/ out of src/.
  • Consumers of this probably have their own build systems, so maybe the Makefile needs to move as well.

@bhess
Copy link

bhess commented Mar 15, 2024

Great, thanks for this initial import!

In OQS we currently import the "standard" branch from pq-crystals and apply a few patches along with the import. May it be worth adding parts of the patch to this repo (e.g., to simplify import to OQS)?

The patches are:

  • Updating the meta.yml files (Name: ML-KEM-(ipd), correct KAT and test vector hashes)
  • Updates the KYBER_NAMESPACE macro
  • Integrate with the SHAKE incremental API in oqs

@planetf1
Copy link
Contributor

The commit needs updating with

git commit --amend --no-edit --signoff

to accept the DCO

Perhaps both @jschanck 's suggestion re: test, and @bhess 's suggestion for integrating some patches to better facilitate later merge, could be raised as distinct issues? (I'd be happy to help out with these or raise those issues if it helps)

Copy link
Contributor

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO needs accepting (see comments)

@planetf1
Copy link
Contributor

planetf1 commented Sep 9, 2024

Closing. New PR open #6

@planetf1 planetf1 closed this Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants