Implement polyvecl_uniform_gamma1 using 4-way Keccak
#251
+93
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
poly_uniform_gamma1_4x
branch
from
67a1c6f to
52e8f98
Compare
This commit adds poly_uniform_gamma1_4x which implements uniform sampling in [-(MLDSA_GAMMA1 - 1), MLDSA_GAMMA1] using 4-way batched Keccak. It then implements polyvecl_uniform_gamma1 using the new batched function. L = 4 is implemented using one call to poly_uniform_gamma1_4x. L = 5 is implemented using one call to poly_uniform_gamma1_4x and one call to poly_uniform_gamma1 L = 7 is implemented using two call to poly_uniform_gamma1_4x (with one polynomial being wasted). Signed-off-by: Matthias J. Kannwischer <[email protected]>
The poly_uniform_gamma1 function is the last one using the stream256 instead of the standard keccak APIs. This commit refactors it to be in-line with the batched implementation as well as the xof128 function. The initialization function is removed and inlined into poly_uniform_gamma1. The CBMC proof is adjusted accordingly. Signed-off-by: Matthias J. Kannwischer <[email protected]>
hanno-becker
force-pushed
the
poly_uniform_gamma1_4x
branch
from
52e8f98 to
142be6c
Compare
| mld_xof256_init(&state); | ||
| mld_xof256_absorb(&state, extseed, MLDSA_CRHBYTES + 2); | ||
|
|
||
| mld_xof256_squeezeblocks(buf, POLY_UNIFORM_GAMMA1_NBLOCKS, &state); |
There was a problem hiding this comment.
This should have a call to mld_xof256_release at the end?
hanno-becker
requested changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s1,s2vectors using 4-way batched Keccak #245poly_uniform_gamma1_4x#212This commit adds poly_uniform_gamma1_4x which implements uniform
sampling in [-(MLDSA_GAMMA1 - 1), MLDSA_GAMMA1] using 4-way batched
Keccak. It then implements polyvecl_uniform_gamma1 using
the new batched function.
L = 4 is implemented using one call to poly_uniform_gamma1_4x.
L = 5 is implemented using one call to poly_uniform_gamma1_4x and one call to
poly_uniform_gamma1
L = 7 is implemented using two call to poly_uniform_gamma1_4x (with one
polynomial being wasted).