Allow easy access to all osu!catch difficulty hit objects in the object inspector #278
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slider ends and slider ticks (converted to fruits and droplets respectively) should be displayed on the osu!catch timeline since they have corresponding difficulty hit objects.
Related to the previous commit. Storing the objects in a field so that a list of `PalpableCatchHitObject` isn't created from scratch on every key press.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the timeline only shows circles, slider starts, and spinners. In osu!catch, slider ticks and slider ends (converted to large droplets and fruits respectively) have difficulty hit objects as well, but it's problematic to see the values since the arrow keys skip them. This PR addresses that. Other modes have no changes.
I set banana showers to be skipped because there are no difficulty hit objects for them.
I haven't touched the look of objects on the timeline, I don't know whether the slider ticks/ends should be shown differently.
Before:
After:
