Skip to content

Conversation

Givikap120
Copy link
Contributor

This should decrease freezes when changing mods.

@stanriders
Copy link
Member

I'm not sure how much I'd like to riddle the code with task.run's for minor gains - I'd rather see if we can leverage update thread for difficulty calculation instead. @tsunyoku what do you think?

@stanriders stanriders added the perfcalc-gui PerformanceCalculatorGUI label Jun 28, 2025
@Givikap120
Copy link
Contributor Author

Givikap120 commented Jun 28, 2025

I'm not sure how much I'd like to riddle the code with task.run's for minor gains - I'd rather see if we can leverage update thread for difficulty calculation instead. @tsunyoku what do you think?

I don't think this is a minor gain at all. Getting freezes constantly is not fun, and on long maps it's making simulate screen incredibly painful to use.
Try calculating because maybe pt 3 with DT1.1x AR10.5 OD10 CS3 mods and you will understand what I'm talking about.

@stanriders
Copy link
Member

2025-06-28.21-19-51.mp4

I don't see the vision sorry - this try was done on a fresh pc boot using hdd so it can be a lot faster on a better setup. Definitely not worth doing adhoc fixes like that for a dev tool, but if you want diffcalc to run without any hitches you should look into refactoring it into an update thread job.

@Givikap120
Copy link
Contributor Author

2025-06-28.21-19-51.mp4
I don't see the vision sorry - this try was done on a fresh pc boot using hdd so it can be a lot faster on a better setup. Definitely not worth doing adhoc fixes like that for a dev tool, but if you want diffcalc to run without any hitches you should look into refactoring it into an update thread job.

On my setup there was 2 second freeze after every action. I don't see how using Task.Run is adhoc when it's used in diffcalc in other screens like profile screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perfcalc-gui PerformanceCalculatorGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants