-
Notifications
You must be signed in to change notification settings - Fork 448
Add triple click to select all in TextBox #6645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The past attempt in #4975 did that and wasn't accepted. This also closes #4974 (can't edit OP). |
Issue linked in OP. Thanks for pointing that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs tests. Not willing to review until there's tests.
Added tests for triple click selecting all and a triple click that is too slow to select. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to feel about the following behaviour:
Screen.Recording.2025-10-07.at.08.52.14.mov
For reference macOS stops changing the selection after the third click and I think that'd be a better behaviour here too.
If you want it to work that way here, I won't fight you over it. I have no strong opinions here. But consider that almost everything else does allow the selection to change (testing of various programs on Windows and Linux): untitled.mp4The most common behavior appears to be (also small behavior change with 95b39dc for dragging, everything I tested this with did not allow text selection to change when dragging while a triple click is ongoing so that's added now) |
Please add a test case for this. |
Test added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no real remaining concerns from me I guess
@peppy maybe check that you're OK with the UX side of this
Small qol feature. I triple click on textboxes a lot and it's a bit jarring to be unable to do this in osu.
If desirable, I could implement this as a whole different event like DoubleClickEvent but I can't think of a use case outside of TextBox so I'm not sure that's worth it. Tried to follow the existing project structure as closely as I could.
Closes #4974