-
Notifications
You must be signed in to change notification settings - Fork 25
Updates to test-client concurrent-connections command #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default behavior of printing the id can cause a lot of output to the console, especially when using this for a typical case of testing bulk initial sync. I'd recommend disabling that option by default, instead of defaulting to printing the id.
Otherwise this looks good to me.
@michaelbarnes I rewrote the logic a bit:
|
This PR introduces small updates to the test-client
concurrent-connections
command, based on feedback from a customer who's using the test-client to perform load-testing. Here's what's changed:concurrent-connections
command has been made the same regardless of themode
param provided i.e. Websocket and HTTP mode now print the same types of messages e.g.checkpoint_complete op_id: ${last_op_id}, ops: ${numOperations}, bytes: ${size}, duration: ${duration}ms, data: [${printData}]
.print
(-p
or--print
) param was added to theconcurrent-connections
command. Developers can provide a field that displays the corresponding values from the synced source database, once the sync has completed. Theid
value will print by default if no argument is provided for the print command.test-client
has been updated with more details on each of the available commands.