-
Notifications
You must be signed in to change notification settings - Fork 60
Permit patching Operator Mono to succeed despite missing glyphs #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…g to remove missing glyphs: Traceback (most recent call last): File "./powerline-fontpatcher", line 144, in <module> raise SystemExit(main(sys.argv[1:])) File "./powerline-fontpatcher", line 141, in main return patch_fonts(args.source_font, args.target_fonts, args.rename_font) File "./powerline-fontpatcher", line 133, in patch_fonts patch_one_font(source_font, target_font, rename_font) File "./powerline-fontpatcher", line 117, in patch_one_font target_font[0xFB01].removePosSub('*') # fi ligature TypeError: No such glyph This commit first checks for the existence of glyphs 0xFB01 and 0xFB02 before attempting to remove them.
That think should be merged. I've lost like 2 hours trying to convert my 'operator mono' font. |
@pie6k how to use fontpatcher ? I dowload the fontpatcher project and let the font in fontpatcher folder , i input the command in terminale fontforge -script /Users/imac/Downloads/fontpatcher/setup.py OperatorMono-Book.otf but console error |
I don't know why this patch isn't merged. It works great.
|
This should be merged. I even covered this in a blog post I wrote two years ago. https://jsatk.us/vim-tmux-italics-and-insanity-9a96b69eeca6 |
can this be merged? |
In support of powerline/fonts#154
Patching Operator Mono produced the following errors due to attempting to remove missing glyphs:
Traceback (most recent call last):
File "./powerline-fontpatcher", line 144, in
raise SystemExit(main(sys.argv[1:]))
File "./powerline-fontpatcher", line 141, in main
return patch_fonts(args.source_font, args.target_fonts, args.rename_font)
File "./powerline-fontpatcher", line 133, in patch_fonts
patch_one_font(source_font, target_font, rename_font)
File "./powerline-fontpatcher", line 117, in patch_one_font
target_font[0xFB01].removePosSub('*') # fi ligature
TypeError: No such glyph
This commit first checks for the existence of glyphs 0xFB01 and 0xFB02 before attempting to remove them.