Completed Pizzeria Lab #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Aug 22, 2024
Comment on lines
+23
to
+26
| private | ||
| def pizza_params | ||
| params.require(:pizza).permit(:name,:description, :pizzeria_id) | ||
| end |
There was a problem hiding this comment.
Suggested change
| private | |
| def pizza_params | |
| params.require(:pizza).permit(:name,:description, :pizzeria_id) | |
| end | |
| private | |
| def pizza_params | |
| params.require(:pizza).permit(:name, :description, :pizzeria_id) | |
| end |
Comment on lines
+4
to
+6
| validates :name, presence: true | ||
| validates :description, presence: true | ||
| end |
There was a problem hiding this comment.
Suggested change
| validates :name, presence: true | |
| validates :description, presence: true | |
| end | |
| validates :name, :description, presence: true | |
| end |
Comment on lines
+5
to
+14
| <%= form_with(model: [@pizzeria, @pizza], local: true ) do |f| %> | ||
|
|
||
| <label>Pizza Name: <%= f.text_field :name %></label><br /> | ||
|
|
||
| <label>Description: <%= f.text_field :description %></label><br /> | ||
|
|
||
| <%= f.hidden_field :pizzeria_id %> | ||
|
|
||
| <%= f.submit %> | ||
| <% end %> |
There was a problem hiding this comment.
Suggested change
| <%= form_with(model: [@pizzeria, @pizza], local: true ) do |f| %> | |
| <label>Pizza Name: <%= f.text_field :name %></label><br /> | |
| <label>Description: <%= f.text_field :description %></label><br /> | |
| <%= f.hidden_field :pizzeria_id %> | |
| <%= f.submit %> | |
| <% end %> | |
| <%= form_with(model: [@pizzeria, @pizza], local: true ) do |f| %> | |
| <label>Pizza Name: <%= f.text_field :name %></label><br /> | |
| <label>Description: <%= f.text_field :description %></label><br /> | |
| <%= f.hidden_field :pizzeria_id %> | |
| <%= f.submit %> | |
| <% end %> |
|
|
||
| <%= link_to "Tell us about a great pizza you had at #{@pizzeria.name}", new_pizzeria_pizza_path(@pizzeria) %> | ||
|
|
||
| <div> |
There was a problem hiding this comment.
This div is not needed.
Comment on lines
+7
to
+15
| <h2>Great eats from: <%= @pizzeria.name %></h2> | ||
| <ul> | ||
| <% @pizzeria.pizzas.each do |pizza| %> | ||
| <br> | ||
| <li> | ||
| <%= link_to pizza.name, pizza %> | ||
| </li> | ||
| <% end %> | ||
| </ul> |
There was a problem hiding this comment.
Suggested change
| <h2>Great eats from: <%= @pizzeria.name %></h2> | |
| <ul> | |
| <% @pizzeria.pizzas.each do |pizza| %> | |
| <br> | |
| <li> | |
| <%= link_to pizza.name, pizza %> | |
| </li> | |
| <% end %> | |
| </ul> | |
| <h2>Great eats from: <%= @pizzeria.name %></h2> | |
| <ul> | |
| <% @pizzeria.pizzas.each do |pizza| %> | |
| <li><%= link_to pizza.name, pizza %></li> | |
| <br /> | |
| <% end %> | |
| </ul> |
Comment on lines
+3
to
+6
| # get '/pizzerias/new', to: 'pizzerias#new', as: 'new_pizzeria' | ||
| # post '/pizzerias', to: 'pizzerias#create', as: 'pizzerias' | ||
| # get '/pizzerias/:id', to: 'pizzerias#show', as: 'pizzeria' | ||
| # get '/pizzerias', to: 'pizzerias#index' |
There was a problem hiding this comment.
Sorry! I realize I completely neglected this file.
| post '/pizzerias', to: 'pizzerias#create', as: 'pizzerias' | ||
| get '/pizzerias/:id', to: 'pizzerias#show', as: 'pizzeria' | ||
| get '/pizzerias', to: 'pizzerias#index' | ||
| resources :pizzas |
There was a problem hiding this comment.
Make sure you only define the routes that you are actually using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Rails Pizzeria Lab