Create and display pizzas #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Please don't commit changes like this for the actual code challenge. Pay attention to what you're committing EVERY TIME.
There was a problem hiding this comment.
Code looks good, spacing could use some work. Adding a line between divs might be nice.
| @@ -0,0 +1,4 @@ | |||
| <h1><%="#{@pizza.name} from "%> | |||
| <%=link_to @pizza.pizzeria.name, pizzeria_path(@pizza.pizzeria)%> | |||
There was a problem hiding this comment.
Suggested change
| <%=link_to @pizza.pizzeria.name, pizzeria_path(@pizza.pizzeria)%> | |
| <%= link_to @pizza.pizzeria.name, pizzeria_path(@pizza.pizzeria) %> |
| <h1><%="#{@pizza.name} from "%> | ||
| <%=link_to @pizza.pizzeria.name, pizzeria_path(@pizza.pizzeria)%> | ||
| </h1> | ||
| <p>Description: <%[email protected]%> |
There was a problem hiding this comment.
Suggested change
| <p>Description: <%=@pizza.description%> | |
| <p>Description: <%= @pizza.description %> |
| @@ -1,2 +1,11 @@ | |||
| <h1 style='margin-top:100px'>Pizzeria name: <%= @pizzeria.name %></h1> | |||
| <p>Address: <%= @pizzeria.address %></p> | |||
|
|
|||
| <p><%= link_to "Tell us about a great pizza you had at #{@pizzeria.name}", new_pizzeria_pizza_path(@pizzeria)%></p> | |||
There was a problem hiding this comment.
Suggested change
| <p><%= link_to "Tell us about a great pizza you had at #{@pizzeria.name}", new_pizzeria_pizza_path(@pizzeria)%></p> | |
| <p><%= link_to "Tell us about a great pizza you had at #{@pizzeria.name}", new_pizzeria_pizza_path(@pizzeria) %></p> |
| <h2>Great eats from <%= @pizzeria.name %></h2> | ||
| <ol> | ||
| <% @pizzeria.pizzas.each do |pizza| %> | ||
| <li><%=link_to pizza.name, pizza_path(pizza) %></li> |
There was a problem hiding this comment.
Suggested change
| <li><%=link_to pizza.name, pizza_path(pizza) %></li> | |
| <li><%= link_to pizza.name, pizza_path(pizza) %></li> |
Comment on lines
+3
to
+7
| resources :pizzerias | ||
|
|
||
| resources :pizzerias do | ||
| resources :pizzas, only: [:new, :create, :show] | ||
| end |
There was a problem hiding this comment.
Whoops!
Suggested change
| resources :pizzerias | |
| resources :pizzerias do | |
| resources :pizzas, only: [:new, :create, :show] | |
| end | |
| resources :pizzerias do | |
| resources :pizzas, only: [:new, :create, :show] | |
| end |
There was a problem hiding this comment.
You shouldn't be deleting migrations. Assume that the migrations that were given to you are already "in production" and can't be undone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.