Fix referenda list collapsing #11796
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const res = ids.map((id, i) => { | ||
| const infoOpt = all[i]; | ||
| const info = infoOpt?.isSome ? infoOpt.unwrap() : undefined; | ||
| const info = infoOpt.unwrap(); |
There was a problem hiding this comment.
Are we sure that a problem will not occur if infoOpt is undefined? Why are we removing the isSome() check before unwrapping the value
There was a problem hiding this comment.
Wherever info is getting used, it makes sure it is not undefined, so It wouldn't break anything. Actually, I am getting back to original implementation here, so removed that isSome check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a UI bug where, after interacting with a referendum (voting or placing a decision deposit) or performing a bounty-related action, the list refresh would only show the updated item and hide the rest until a manual page reload. The update ensures that a full list refresh occurs after transactions so all items remain visible without requiring a reload.
Screen.Recording.2025-08-25.at.13.04.24.mov