Skip to content

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Aug 14, 2025

This PR changed the total keys from YY-YY All Programs Total to YYYY-YYYY All Programs Total.
You will see changes in this endpoint

http://localhost:5000/pdl/allprograms
image

Please note that the frontend should be updated accordingly policy-design-lab/pdl-frontend#421

…yy-yy-format-start-and-end-years-to-yyyy-yyyy-format
Copy link
Contributor

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and matches pivot tables for Title I and SNAP. We identified small changes in SNAP and Title I and it looks like the production DB was never updated with the latest Title I changes.

@navarroc
Copy link
Contributor

Just to add more to this. If we merge this and use it with the Production DB without updating the DB, the numbers match what is currently on prod. The real issue is, do we make a data-ingestion release because the develop branch of data-ingestion has updates not yet applied to prod and they change the numbers slightly for Title I and SNAP; however, the values seem to match small pivot table samples.

Copy link
Member

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this change currently deployed in the development instance. I will approve.

@ylyangtw ylyangtw merged commit 10f1d46 into develop Aug 20, 2025
1 check passed
@ylyangtw ylyangtw deleted the 272-feature-change-all-programs-key-from-yy-yy-format-start-and-end-years-to-yyyy-yyyy-format branch August 20, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Change all programs key from YY-YY format (start and end years) to YYYY-YYYY format.
3 participants