Skip to content

Implement merge checker #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implement merge checker #31

wants to merge 5 commits into from

Conversation

rem1niscence
Copy link
Contributor

Implements merge checker to verify eth 2.0 nodes

@height
Copy link

height bot commented Sep 15, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

blockjoe
blockjoe previously approved these changes Sep 15, 2022
View reviewed changes
Copy link

@blockjoe blockjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines of business logic dealing specifically determining the merge state look good here to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockjoe blockjoe blockjoe left review comments

@crisog crisog Awaiting requested review from crisog

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rem1niscence @blockjoe