[WIP] feat(sdk): domain specific hashing for signature #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
changed the title
poszu
reviewed
May 19, 2025
Comment on lines
+3
to
+4
| pub const SIG_PREFIX_GAS_PRICE_ATTESTATION: &[u8] = b"ATT_GAS_PRICE"; | ||
| pub const SIG_VERSION_GAS_PRICE_ATTESTATION: u8 = 1; |
There was a problem hiding this comment.
Do we need to separate prefix and version? Isn't it equal to have the version in the prefix like:
"ATT_GAS_PRICE"for version 0"ATT_GAS_PRICE_1"for version 1
and so on?
| pub const SIG_VERSION_RECEIPT_ATTESTATION: u8 = 1; | ||
|
|
||
| pub trait SigHashable { | ||
| fn hash_for_signature(&self) -> Hash; |
There was a problem hiding this comment.
Should it also take a network-specifc prefix like this
Suggested change
| fn hash_for_signature(&self) -> Hash; | |
| fn hash_for_signature(&self, network_prefix: &[u8]) -> Hash; |
where this prefix would be different on each network (e.g. devnet, testnet, mainnet etc.) so that signatures signed for devnet cannot be re-used on other networks?
|
@poszu marking this PR as draft, I need to implement an EIP712-aligned solution instead of a custom one. I will work on that soon |
ogabrielides
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.