This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Update to areas.Task methods #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `find` method on the `Task` area to retrieve a single task by the id. This has been named `Task.find` to remain consistent with other areas. The `get` method is not consistent with other areas though which use `find_all` or `find_all_by_*`. So `find_all` has been added and a comment placed in `get` to deprecate this method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
findmethod on theTaskarea to retrieve a single task by the id. This has been namedTask.findto remain consistent with other areas. Thegetmethod is not consistent with other areas though which usefind_allorfind_all_by_*. Sofind_allhas been added and a comment placed ingetto deprecate this method.