Fix minzoom bug and add some unit tests #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two small issues, and adds a set of tests which would have detected both issues.
apenney
force-pushed
the
ap/fix-tileset-bug
branch
from
3bf6846 to
5a50c33
Compare
pnorman
requested changes
Mar 28, 2025
| """ | ||
| A fake implementation of Storage for testing purposes. | ||
| """ | ||
| def __init__(self, calls: List[str], rets: queue.SimpleQueue) -> None: |
There was a problem hiding this comment.
You can use list instead of List
| tile: Tile, | ||
| _layers: Dict[str, bytes], | ||
| _render_time: int = 0 | ||
| ) -> Optional[Union[datetime.datetime, str]]: |
There was a problem hiding this comment.
The signature of save_tile is save_tile(self, tile: Tile, layers: dict[str, bytes]), so the fake one should match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two small issues, and adds a set of tests which would have detected both issues.