misc: ci warnings rollup #7642
Draft
misc: ci warnings rollup #7642
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clang` emits `-Wsometimes-uninitialized` for the error case of `prepare_local_lpids` as `*num_worlds_out` is set to an uninitialized `num_worlds` upon jump to `fn_exit`. The fix is to move the initialization of `num_worlds` prior to the check.
`clang` doesn't have an equivalent to `-Wdiscarded-qualifiers`, so we shouldn't bother setting the ignore pragma.
`f16_sum/store/load` are unused when `MPIR_FLOAT16_CTYPE` exists, we should only include the function declaration and definitions if we need the software implementation.
`ucs_status_ptr_t` is a typedef for `void *` and `UCS_OK` is an enum which equals `0`. `NULL` and `UCS_OK` are equivalent for the purposes of `status`.
lowpolyneko
force-pushed
the
ewong/warnings-rollup
branch
from
bb84dd9 to
50e3e0d
Compare
|
test: mpich/custom/spack |
3 similar comments
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
3 similar comments
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/ch4/ofi |
|
test: mpich/custom/spack |
8 similar comments
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
|
test: mpich/custom/spack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is a roll-up of various minor fixes for warning emits from our nightly CI. Most of these are emits which only present themselves on
clang. Comments are welcome if these fixes could be improved. :)Meta: I'm intending on using this PR as a testbed for the new
mpich-review-spackCI job which I've been workshopping. Please hold off merging this so I have a place to test the job and not pollute the comments of other PRs.Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.