ch4/ofi: fix MPIDI_OFI_rndv_need_pack for reg_host #7542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
changed the title
|
This patch has issues: https://jenkins-pmrs.cels.anl.gov/job/mpich-review-ch4-gpu-ofi/411/ |
11 tasks
hzhou
force-pushed
the
2508_ofi_needpack
branch
2 times, most recently
from
5be040c to
a19534a
Compare
When we use malloc for pack buffer and when it is used for copying from and to GPU, we potentially can incur expensive registration cost every time. This is the case with ZE. Use pipeline_pool allows reusage of pack buffers.
hzhou
force-pushed
the
2508_ofi_needpack
branch
from
a19534a to
f769f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When we use malloc for pack buffer and when it is used for copying from
and to GPU, we potentially can incur expensive registration cost every
time. This is the case with ZE. Use pipeline_pool allows re-usage of pack
buffers.
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.