test: add ch4:ofi --hasgpu performance testfile #7519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowpolyneko
force-pushed
the
ewong/bench-tests
branch
from
e7857c0 to
3baa7ef
Compare
lowpolyneko
changed the title
hzhou
requested changes
Jul 24, 2025
lowpolyneko
force-pushed
the
ewong/bench-tests
branch
2 times, most recently
from
9ab0ecb to
ee5b6c7
Compare
lowpolyneko
force-pushed
the
ewong/bench-tests
branch
from
4b138e6 to
eeaaaff
Compare
|
Might be worth integrating #7536 into this depending on need. |
|
Looks good. How about squash some commits? Each commit should be self-contained and do not do two things at once. But we don't have to keep multiple commits history showing how a single thing (e.g. adding the -gpu option to tests) was developed. That latter has little value for maintenance. |
lowpolyneko
force-pushed
the
ewong/bench-tests
branch
from
a89674b to
03cd8c1
Compare
|
Agreed, squashed the PR to three commits. Feel free to squash and merge to reduce it further if needed. |
hzhou
requested changes
Aug 14, 2025
Introduces a testlist running latency and bandwidth tests for senddev and recvdev (host/device) combinations. The result of this testlist is fed into gnuplot by the test suite to generate performance graph artifacts.
Reintroduces the `gpu` testlist flag removed in PR pmodels#7506 as `hasgpu=?`. However, it is now implemented as a GPU library dependency requirement which skips tests if they are not detected by Automake. Also adds a corresponding `MPITEST_HASGPU` environment variable for manual testing.
lowpolyneko
force-pushed
the
ewong/bench-tests
branch
from
03cd8c1 to
529ff88
Compare
hzhou
changed the title
hzhou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds a performance
testlisttotests/mpi/benchfor a future ch4:ofi gpu performance build job. To be merged in once the test is stabilized.Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.