Fix error in Manhattan plot for single chromosome #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to use ManhattanPlot on data containing a single chromosome, a runtime error is encountered. Seems it was previously reported in plotly#486 but the cause was not determined. From looking at the code, it seems like the `name` parameter was incorrectly included inside the `marker` dict, when it should have been a direct kwarg.
acarapetis
requested review from
alexcjohnson and
HammadTheOne
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use ManhattanPlot on data containing a single chromosome, a runtime error is encountered. Seems it was previously reported in #486 but the cause was not determined. From looking at the code, it seems like the
nameparameter was incorrectly included inside themarkerdict, when it should have been a direct kwarg.I've also updated the capitalization to match the multi-chromosome case.