Disable initialize_documentation for subtemplates #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
force-pushed
the
no-docs-for-subtemplate
branch
from
ef04e51 to
d49940f
Compare
stevepiercy
requested changes
Apr 16, 2025
stevepiercy
approved these changes
Apr 16, 2025
|
Completely overlooked this way of implementation. Works great + super clean! LGTM. |
|
I don't know why CI doesn't report its status here. It's all green at https://github.com/plone/cookieplone-templates/actions/runs/14487515096. I'll hold off on merging, just in case I'm mistaken, and to let @davisagli or @ericof take a look at it. |
|
@stevepiercy I also don't understand why CI was not triggered. Your new commit should have triggered a pull_request.synchronize event, which should have started the workflow. I'll make another commit just to bump it, but let's watch other PRs to see if it's a broader issue vs a GitHub glitch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposal instead of #204. Set the
enabledflag for the subtemplate based on theinitialize_documentationvariable, and set that variable to 0 when calling the frontend and backend addon templates as subtemplates./cc @ujsquared