-
-
Notifications
You must be signed in to change notification settings - Fork 9
fix: change Makefile task name #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the name of the target means it will run unless there is a file named venv
, which is not the best solution.
I think the real problem is that the requirements-mxdev.txt
target doesn't list its dependencies, see my explanation here: #215 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely not the correct fix. See my comment in #215 (comment) and a related issue in documentation with a suggested and untested fix plone/documentation#1938.
This reverts commit 8066d45.
templates/sub/project_settings/{{ cookiecutter.__folder_name }}/backend/Makefile
Outdated
Show resolved
Hide resolved
templates/sub/project_settings/{{ cookiecutter.__folder_name }}/backend/Makefile
Outdated
Show resolved
Hide resolved
I would like to see the prerequisites also in |
@ksuess I have updated the PR with those changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right (or at least, more right 😛) to me
@erral Thanks for the fix! |
Fixes #215