Skip to content

fix: delete the instance configuration in make clean #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

erral
Copy link
Member

@erral erral commented Apr 16, 2025

We already have make remove-data to remove the data, make clean should not wipe the data. See #91 and #103

Fixes #213

@davisagli davisagli requested a review from ericof April 16, 2025 06:00
@stevepiercy
Copy link
Contributor

I ran through the project generation, cd project-title, make install. Here's the resulting directory tree.

$ tree -L 5 backend/instance/  
backend/instance/
├── etc
│   ├── site.zcml
│   ├── zope.conf
│   └── zope.ini
└── var
    ├── blobs
    │   ├── 0x00
    │   │   └── 0x00
    │   │       └── 0x00
    │   └── tmp
    ├── cache
    │   ├── 45a89972949c31ca1bed45280d2a45c3.py
    │   ├── __pycache__
    │   │   ├── 45a89972949c31ca1bed45280d2a45c3.cpython-312.pyc
    │   │   ├── a9262aacc5bd3bff9f2562d46ba123af.cpython-312.pyc
    │   │   ├── b32eaa48df8a412b3f7d07e9671e315d.cpython-312.pyc
    │   │   └── cf0de291133736baf931adb6c10f0633.cpython-312.pyc
    │   ├── a9262aacc5bd3bff9f2562d46ba123af.py
    │   ├── b32eaa48df8a412b3f7d07e9671e315d.py
    │   └── cf0de291133736baf931adb6c10f0633.py
    ├── filestorage
    │   ├── Data.fs
    │   ├── Data.fs.index
    │   ├── Data.fs.lock
    │   └── Data.fs.tmp
    └── log

12 directories, 15 files

Also there are two open PRs that relate to this issue:

I think it's OK to merge this PR, assuming that the open documentation PRs are both aligned with reality.

Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your improvement!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make clean wipes the entire instance
4 participants