Acsr patch – update broken link to changelog docs in two CHANGELOG.md files #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Broken Link
…elog-Docs2 Update CHANGELOG.md
stevepiercy
approved these changes
Apr 15, 2025
|
Let's make sure everything is green, then you can merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link in the current CHANGELOG.md boilerplate pointing to the docs is broken.
I tried to find a current valid link as replacement and provided it as PR.
Please review and replace with a more appropriate link if needed.
broken link:
https://6.docs.plone.org/volto/developer-guidelines/contributing.html#create-a-pull-request
expected possible destination used as replacement:
https://6.docs.plone.org/contributing/index.html#contributing-change-log-label
Suggestion:
Use a multi step canonical redirection for this link in the future including a revision/version
e.g. Specific link -> generic link -> current link -> destination
The broken one is present in cookieplone generated projects with this current setup:
'__generator_signature': 'Generated using Cookieplone (0.9.6) and cookieplone-templates (a83957d) on 2025-04-15 20:53:09.072397'})})