Skip to content

Add horse-with-no-namespace as test dependency for packages #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

Add horse-with-no-namespace as test dependency for packages #209

merged 3 commits into from
Apr 14, 2025

Conversation

ericof
Copy link
Member

@ericof ericof commented Apr 13, 2025

@ericof ericof added the 01 type: bug something does not work label Apr 13, 2025
@ericof ericof requested review from davisagli and wesleybl April 13, 2025 17:38
@ericof ericof self-assigned this Apr 13, 2025
stevepiercy
stevepiercy requested changes Apr 13, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo

@ericof @stevepiercy
Update news/208.bugfix
c4b1eb6 
Co-authored-by: Steve Piercy <[email protected]>
@ericof ericof requested a review from stevepiercy April 14, 2025 01:11
stevepiercy
stevepiercy approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News LGTM. Maybe get a technical review from @davisagli or @wesleybl?

wesleybl
wesleybl approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This works!

@wesleybl
Copy link
Member

Just out of curiosity, I removed src/collective/__init__.py and used:

[project]
version = "0.1.0"
# dynamic = ["version"]

# [tool.hatch.version]
# path = "src/collective/__init__.py"

[tool.hatch.metadata]
allow-implicit-namespace-packages = true

So horse-with-no-namespace didn't solve the problem. @davisagli is it necessary to have __init__.py for it to work?

@wesleybl
Copy link
Member

So horse-with-no-namespace didn't solve the problem. @davisagli is it necessary to have init.py for it to work?

@davisagli I tested it again and it worked. I must have done something wrong.

@ericof
Copy link
Member Author

ericof commented Apr 14, 2025

What is the name of your package? Just collective?

@wesleybl
Copy link
Member

@ericof I tested it on the generated test package collective.addon. It worked!

@ericof ericof merged commit 2d6ff9d into main Apr 14, 2025
32 checks passed
@ericof ericof deleted the issue-208-namespaces branch April 14, 2025 18:05
@wesleybl wesleybl mentioned this pull request Apr 14, 2025
Closed
davisagli
davisagli reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli left review comments

@stevepiercy stevepiercy stevepiercy approved these changes

@wesleybl wesleybl wesleybl approved these changes

Assignees

@ericof ericof

Labels
01 type: bug something does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add horse-with-no-namespace as test dependency for newly created backend_addons
4 participants
@ericof @wesleybl @davisagli @stevepiercy