This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Add support for heroku 24 stack #28
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to our own version of the apt buildpack
|
@jasonsbrooks I was able to get this to work on Heroku with Playwright 1.48 by correcting the Any reason you had to override the apt buildpack? I would like to create a PR with my changes, but not sure if the override should be included. |
truthdoug
reviewed
Jan 27, 2025
| topic "Installing System Dependencies" | ||
|
|
||
| APT_BUILDPACK="https://github.com/heroku/heroku-buildpack-apt" | ||
| APT_BUILDPACK="https://github.com/KinnTech/heroku-buildpack-apt" |
This was referenced Feb 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the heroku-24 stack.
Note - this seems to be blocked by issues mentioned in microsoft/playwright#30368 . Facing an error when pushing due to
libasound2. Submitting this as a draft to refer to in the associated issue.