Skip to content

Conversation

@dlcole3
Copy link
Collaborator

@dlcole3 dlcole3 commented Jul 8, 2025

This PR address three minor problems

  • The get_upper_bounds function when monotonic = true would only return a one element vector because a parenthesis was in the wrong place
  • If a graph was formed via the induce_subgraph command in Plasmo, the constructor function would error at initialization. I changed how it determines the linking variables. This was previously a bottleneck point because it was calling union or intersect and was replaced by calling source_graph on a node (see Re-structure single graph model for Benders algorithm #25). I think the new method is roughly as efficient as the source_graph method, and some preliminary benchmarking suggests this is the case.
  • Base.show and Base.print were not implemented for the BendersAlgorithm. For large problems, the display in the REPL was really clunky and not helpful, so this PR adds a display ability.

@dlcole3 dlcole3 merged commit 8228ae5 into plasmo-dev:main Jul 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant