Skip to content

[Submission List] | Reviewer list - Dashboard, Duplicate reviews are populated. #11252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
Tribunal33 opened this issue Apr 9, 2025 · 3 comments
Open
1 task done
Assignees
Labels
Bug:1:Minor A bug found in uncommon paths, with low consequences, limited users or has an easy workaround
Milestone

Comments

@Tribunal33
Copy link
Contributor

Valid Title

  • I have updated the title to accurately reflect the bug description

Description

Noticed that previous review round review request are being populated in the reviewer submission view. I'm unsure if it would matter at what stage the review was in so I will only do the overdue request from round 1 and a new review request in round 2. I felt like this would be a common use case as an editor wanting to start a new round with fresh reviewers.

Precondition: Start with a submission in the review stage with at least one reviewer added. You can create a new submission and work it through but it isn't necessary and won't reflect from where the steps will start from.

Steps to Reproduce

  1. Login with User/Role with editor permissions
  2. Navigate to a submission in the reivew round and has at least one reviewer added
  3. Select the three dots menu and edit the review request of the reviewer
  4. Edit the response due date to before the current date so that it will be overdue
  5. Select OK to save
  6. Select Create New Review Round
  7. Select Add Reviewer after new round is created
  8. Select the same reviewer from the previous round with overdue status
  9. Select the three dots and Login As this reviewer
  10. Observe the submission dashboard of this reviewer

Expected Result

There are two solutions that I would be comfortable with.

  1. Only show current review round review requests in the submission list. Make sure to keep the access to previous review round decisions
  2. Update the editorial message with something like "This review request has moved to another round" and remove the Respond to Request button

This is the current way to see previous review round details as outlined in #9453
Image

Actual Result

There are two reviews to respond to. Only the most recent review round is needed to be displayed (option 1).

Image

Environment Details

No response

Application Version

OJS, OMP, OPS 3.5.0 RC2

Logs

No response

Additional Information

No response

@Tribunal33 Tribunal33 added the Bug:1:Minor A bug found in uncommon paths, with low consequences, limited users or has an easy workaround label Apr 9, 2025
@Tribunal33 Tribunal33 added this to the 3.5 Internal milestone Apr 9, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 16, 2025
@Vitaliy-1
Copy link
Contributor

Vitaliy-1 commented Apr 16, 2025

PRs stable 3.5.0
pkp-lib: #11285
tests OJS: pkp/ojs#4841
tests OMP: pkp/omp#1961

main
pkp-lib: #11306

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 21, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 21, 2025
@Vitaliy-1
Copy link
Contributor

Ready for review! @jardakotesovec, do you have time to take a look?

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 22, 2025
Vitaliy-1 added a commit that referenced this issue Apr 22, 2025
#11252 Show only reviews in the last round in action-required view
Vitaliy-1 added a commit that referenced this issue Apr 22, 2025
#11252 Show only reviews from the latest round by reviewer ID
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 23, 2025
@Vitaliy-1 Vitaliy-1 reopened this Apr 23, 2025
@Vitaliy-1
Copy link
Contributor

PR stable 3.5.0
pkp-lib: #11314
tests OMP: pkp/omp#1967
tests OJS: pkp/ojs#4850

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 23, 2025
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Apr 24, 2025
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Apr 24, 2025
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Minor A bug found in uncommon paths, with low consequences, limited users or has an easy workaround
Projects
None yet
Development

No branches or pull requests

3 participants