[Submission List] | Reviewer list - Dashboard, Duplicate reviews are populated.

[Tribunal33]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

Noticed that previous review round review request are being populated in the reviewer submission view. I'm unsure if it would matter at what stage the review was in so I will only do the overdue request from round 1 and a new review request in round 2. I felt like this would be a common use case as an editor wanting to start a new round with fresh reviewers.

Precondition: Start with a submission in the review stage with at least one reviewer added. You can create a new submission and work it through but it isn't necessary and won't reflect from where the steps will start from.

Steps to Reproduce

1. Login with User/Role with editor permissions
2. Navigate to a submission in the reivew round and has at least one reviewer added
3. Select the three dots menu and edit the review request of the reviewer
4. Edit the response due date to before the current date so that it will be overdue
5. Select OK to save
6. Select Create New Review Round
7. Select Add Reviewer after new round is created
8. Select the same reviewer from the previous round with overdue status
9. Select the three dots and Login As this reviewer
10. Observe the submission dashboard of this reviewer

Expected Result

There are two solutions that I would be comfortable with.

1. Only show current review round review requests in the submission list. Make sure to keep the access to previous review round decisions
2. Update the editorial message with something like "This review request has moved to another round" and remove the Respond to Request button

This is the current way to see previous review round details as outlined in #9453

Actual Result

There are two reviews to respond to. Only the most recent review round is needed to be displayed (option 1).

Environment Details

No response

Application Version

OJS, OMP, OPS 3.5.0 RC2

Logs

No response

Additional Information

No response

[Vitaliy-1]

PRs stable 3.5.0
pkp-lib: #11285
tests OJS: pkp/ojs#4841
tests OMP: pkp/omp#1961

main
pkp-lib: #11306

[Vitaliy-1]

Ready for review! @jardakotesovec, do you have time to take a look?

[Vitaliy-1]

PR stable 3.5.0
pkp-lib: #11314
tests OMP: pkp/omp#1967
tests OJS: pkp/ojs#4850

main pkp-lib: #11350

[Vitaliy-1]

Not closing the issue as it still requires testing as it affects different parts of the system

[Tribunal33]

@Vitaliy-1 a few questions.

1. Should a declined submission show this when going to declined view and selecting view action button?

2. When reviewing a previous review round in which it was declined I'm getting this error
   [Fri May 02 16:00:34.336083 2025] [php:notice] [pid 5452:tid 1896] [client ::1:63995] BadMethodCallException: Call to undefined method Illuminate\\Database\\Eloquent\\Builder::withEventType() in C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\Traits\\ForwardsCalls.php:67\nStack trace:\n#0 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\Traits\\ForwardsCalls.php(36): Illuminate\\Database\\Eloquent\\Builder::throwBadMethodCallException('withEventType')\n#1 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Database\\Eloquent\\Builder.php(2123): Illuminate\\Database\\Eloquent\\Builder->forwardCallTo(Object(Illuminate\\Database\\Query\\Builder), 'withEventType', Array)\n#2 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\api\\v1\\reviews\\PKPReviewController.php(188): Illuminate\\Database\\Eloquent\\Builder->__call('withEventType', Array)\n#3 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\CallableDispatcher.php(40): PKP\\API\\v1\\reviews\\PKPReviewController->getHistory(Object(Illuminate\\Http\\Request), 'publicknowledge', 'v1', '7', '16')\n#4 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Route.php(244): Illuminate\\Routing\\CallableDispatcher->dispatch(Object(Illuminate\\Routing\\Route), Object(Closure))\n#5 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Route.php(215): Illuminate\\Routing\\Route->runCallable()\n#6 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Routing\\Router.php(808): Illuminate\\Routing\\Route->run()\n#7 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(170): Illuminate\\Routing\\Router->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))\n#8 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\classes\\middleware\\HasRoles.php(75): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))\n#9 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(209): PKP\\middleware\\HasRoles->handle(Object(Illuminate\\Http\\Request), Object(Closure), Object(Illuminate\\Support\\Collection))\n#10 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\classes\\middleware\\HasContext.php(35): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))\n#11 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(209): PKP\\middleware\\HasContext->handle(Object(Illuminate\\Http\\Request), Object(Closure))\n#12 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\classes\\middleware\\HasUser.php(35): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))\n#13 C:\\xampp\\htdocs\\ojs-main\\ojs\\lib\\pkp\\lib\\vendor\\laravel\\framework\\src\\Illuminate\\Pipeline\\Pipeline.php(209):
   and this popup
   

[Vitaliy-1]

@Tribunal33, are there additional steps to reproduce the issue? I've tried to make a new submission, assign a reviewer, make a review and then decline submission in both, OMP and OJS, and am able to view this review as a reviewer and journal manager.

Also have tried so far:

1. Create a second review round and then decline
2. Create a new review round, assign the same reviewer and then decline. Reviewer is able to make a review in this case - potential field for improvements.
3. Create review rounds in both review stages (OMP), assign the same reviewer and decline a submission.

[Tribunal33]

Hi @Vitaliy-1 I tried these on OJS and OMP stable 3_5_0.
For the first one: As a reviewer decline a review request and go to the decline view in side navigation. Locate the declined review and click View.

For the second one here are the short form steps:

1. As editor add some reviewers.
2. As one of the reviewers go decline a review.
3. As editor create a new review round.
4. Add the same editors.
5. Login as the previous reviewer that previously declined the review
6. Open up the initial review page
7. Select Read Round 1 Review (round 1)

[Vitaliy-1]

PRs

stable-3_5_0
pkp-lib: #11380
ui-library: pkp/ui-library#617
tests OJS: pkp/ojs#4872

main
pkp-lib: #11383
ui-library: pkp/ui-library#618

[Vitaliy-1]

@jardakotesovec, can you take a look at the PRs?

[Tribunal33]

@Vitaliy-1 ok original bug passes as well as special case 1 with decline view authorization problems and previously decline round being read isn't causing an error anymore.

Original Bug: No longer duplicated with decline or overdue review with second round
Special case 1: Decline reviews now no longer have a view link and is visible while the main round review is in decline state
Special case 2: Decline reviews from previous round does not throw an error. It just displays an empty blade with title of submission