pkp/pkp-lib#11252 Bug fix, Always query for selected stage in the managers

Author: jardakotesovec

src/managers/ReviewerManager/ReviewerManager.vue

@@ -78,6 +78,7 @@ const Components = {
 
 const props = defineProps({
 	submission: {type: Object, required: true},
+	submissionStageId: {type: Number, required: true},
 	reviewRoundId: {type: Number, required: true},
 	redactedForAuthors: {type: Boolean, required: false, default: false},
 	componentForms: {type: Object, required: true},

src/managers/ReviewerManager/reviewerManagerStore.js

@@ -78,7 +78,7 @@ export const useReviewerManagerStore = defineComponentStore(
 		function getActionArgs(additionalArgs = {}) {
 			return {
 				submission: props.submission,
-				submissionStageId: props.submission.stageId,
+				submissionStageId: props.submissionStageId,
 				reviewRoundId: props.reviewRoundId,
 				componentForms: props.componentForms,
 				...additionalArgs,

src/managers/ReviewerManager/useReviewerManagerActions.js

@@ -30,14 +30,17 @@ export const Actions = {
 export function useReviewerManagerActions() {
 	const {t, localizeSubmission} = useLocalize();
 
-	function reviewerAddReviewer({submission, reviewRoundId}, finishedCallback) {
+	function reviewerAddReviewer(
+		{submission, reviewRoundId, submissionStageId},
+		finishedCallback,
+	) {
 		const {openLegacyModal} = useLegacyGridUrl({
 			op: 'showReviewerForm',
 			component: 'grid.users.reviewer.ReviewerGridHandler',
 			params: {
 				selectionType: pkp.const.REVIEWER_SELECT_ADVANCED_SEARCH,
 				submissionId: submission.id,
-				stageId: submission.stageId,
+				stageId: submissionStageId,
 				reviewRoundId,
 			},
 		});

src/pages/workflow/composables/useWorkflowConfig/workflowConfigAuthorOJS.js

@@ -131,7 +131,7 @@ export const WorkflowConfig = {
 				props: {
 					namespace: 'SUBMISSION_FILES',
 					submission: submission,
-					submissionStageId: submission.stageId,
+					submissionStageId: selectedStageId,
 				},
 			});
 
@@ -168,6 +168,7 @@ export const WorkflowConfig = {
 					component: 'ReviewerManager',
 					props: {
 						submission: submission,
+						submissionStageId: selectedStageId,
 						reviewRoundId: selectedReviewRound?.id,
 						redactedForAuthors: true,
 						componentForms: pageInitConfig.componentForms,
@@ -241,7 +242,7 @@ export const WorkflowConfig = {
 				props: {
 					namespace: 'COPYEDITED_FILES',
 					submission: submission,
-					submissionStageId: submission.stageId,
+					submissionStageId: selectedStageId,
 				},
 			});
 

src/pages/workflow/composables/useWorkflowConfig/workflowConfigAuthorOMP.js

@@ -48,7 +48,7 @@ export const WorkflowConfig = {
 				props: {
 					namespace: 'SUBMISSION_FILES',
 					submission: submission,
-					submissionStageId: submission.stageId,
+					submissionStageId: selectedStageId,
 				},
 			});
 
@@ -79,6 +79,7 @@ export const WorkflowConfig = {
 					component: 'ReviewerManager',
 					props: {
 						submission: submission,
+						submissionStageId: selectedStageId,
 						reviewRoundId: selectedReviewRound?.id,
 						redactedForAuthors: true,
 						componentForms: pageInitConfig.componentForms,
@@ -152,7 +153,7 @@ export const WorkflowConfig = {
 				props: {
 					namespace: 'COPYEDITED_FILES',
 					submission: submission,
-					submissionStageId: submission.stageId,
+					submissionStageId: selectedStageId,
 				},
 			});
 

src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js

@@ -329,6 +329,7 @@ export const WorkflowConfig = {
 				component: 'ReviewerManager',
 				props: {
 					submission: submission,
+					submissionStageId: selectedStageId,
 					reviewRoundId: selectedReviewRound?.id,
 					componentForms: pageInitConfig.componentForms,
 					recommendations: pageInitConfig.recommendations,

src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOMP.js

@@ -208,6 +208,7 @@ export const WorkflowConfig = {
 				component: 'ReviewerManager',
 				props: {
 					submission: submission,
+					submissionStageId: selectedStageId,
 					reviewRoundId: selectedReviewRound?.id,
 					componentForms: pageInitConfig.componentForms,
 				},