-
-
Notifications
You must be signed in to change notification settings - Fork 21
snowcap: add TextInput widget #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
snowcap: add TextInput widget #369
Conversation
33b380b
to
756d3af
Compare
@Ottatop do you have thought on that ? Most The second point is only for types without a default implementation. The alternative is to hardcode our own default when the translation between protobuf & iced types fails. |
Agree, it would be best to crack down on these panics (especially if anyone wants to make protobuf bindings), though I strongly recommend doing this in another PR seeing as this one's already up to 2.5k lines |
Agree, I'll only try to remove the ones introduced by this PR and removable :) |
7998627
to
d4aa251
Compare
Allright, I think that's all. FYI, the PR is on top of #364. because I needed some of the changes from that PR, and it makes for a cleaner history that cherry-picking the commits I need (plus the eventual rebase hell if I discovered some issue in that PR). It should rebase cleanly should you choose to first pull the other one, and then rebase + merge this one (which could also be easier to review, I guess ?) OTOH, you can also close the other one and track everything here if you prefer. |
Some widget may create multiple events at the same time. Batching them allows the config to handle all events before calling program::view()
Surface::update can be called again after sending events while the config is still busy handling previous ones, or the new view definition is in-flight. With this commit, we buffer new events until after the new view is received.
d4aa251
to
2164441
Compare
2164441
to
073e8c2
Compare
The title say it all.
This PR adds TextInput widget, which will be useful as a building block for e.g. prompts.
On top of that, I've enabled support for key-repetition so the prompt themselves feel more natural.
TODO:
find & remove server-side except() and raw unwrap()Postponed to [API] Gracefully handle protobuf translation issues #370add a TryFromApi trait so we can log error iso crashing ?