[fix] no 'update' perm needed for 'create' dataobject operation #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Here is my explanation. |
|
I have read the CLA Document and I hereby sign the CLA |
|
@pierre-kubica As this is a bugfix, could you please rebase the PR to 1.9? Thanks |
|
@pierre-kubica There are still commits, that don't belong to your PR. |
pierre-kubica
force-pushed
the
pierre-kubica-patch-1
branch
from
d31b88e to
b5d3b23
Compare
* pimcore update * remove deprecations * Apply php-cs-fixer changes
Update pimcore/pimcore version.
* add nesbot/carbon to composer, adapt to new version * add nesbot/carbon to composer, adapt to new version
* Update composer.json * Update composer.json dependencies and PHP version * fix executeQuery * Update 01_Upgrade_Notes.md * revert composer requirement with dev branches * Remove outdated upgrade note for version 1.10.0
* Add concept of IsValidDataObjectTriggerEvent. * Apply php-cs-fixer changes * update name of event --------- Co-authored-by: Alex Rothberg <[email protected]> Co-authored-by: laticrete-pimcore <[email protected]>
* [Task] Remove deprecations (pimcore#935) * Removed deprecations, added upgrade notes * Improvements to readability * Apply php-cs-fixer changes * Code format * Removed config related to merge operator * Added field type for table query type definition. (pimcore#883) * Update 01_Upgrade_Notes.md (pimcore#936) * [Bug] Introduce numeric-prefix for table (pimcore#937) * Introduce numeric-prefix for table * Apply php-cs-fixer changes * [Improvement]: Add timezone indication for outputted date/datetime values (pimcore#938) * Added timezone indication * Apply php-cs-fixer changes * Added specific client safe exception * Apply php-cs-fixer changes * Added check for pimcore version in format function * Apply php-cs-fixer changes * Removed unnecessary checks * Apply php-cs-fixer changes * Removed unnecessary checks * Apply php-cs-fixer changes * Removed unnecessary method * Apply php-cs-fixer changes * Added creationDate/modificationDate for data objects, assets and asset folder * Apply php-cs-fixer changes * Added datetime resolve for metadata in assets * Apply php-cs-fixer changes * Update upgrade notes, added resolver for object folder and document folder types * Apply php-cs-fixer changes * Update upgrade notes * Fix automatic tests * Apply php-cs-fixer changes * Fix automatic tests * Added date resolver for translation type * Apply php-cs-fixer changes * Removed typo * Update src/GraphQL/DataObjectQueryFieldConfigGenerator/Date.php Co-authored-by: Matthias Schuhmayer <[email protected]> * Update src/GraphQL/Exception/InvalidFieldDefinitionException.php Co-authored-by: Matthias Schuhmayer <[email protected]> * Apply php-cs-fixer changes --------- Co-authored-by: Matthias Schuhmayer <[email protected]> * Remove deprecated config setting enable_authenticator_manager * Adding return types to symfony extension methods * Adding return types to compiler pass methods * Change to attributes * Add return types --------- Co-authored-by: mcop1 <[email protected]> Co-authored-by: Vladimir Malik <[email protected]> Co-authored-by: Matthias Schuhmayer <[email protected]> Co-authored-by: mattamon <[email protected]>
pierre-kubica
force-pushed
the
pierre-kubica-patch-1
branch
from
b5d3b23 to
cf99181
Compare
|
|
Is it correct now ? |
|
@pierre-kubica Unfortunately not, the best thing would be to open a new PR with 1.9 as base branch and close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #961