Skip to content

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 4, 2025

What does this PR aim to accomplish?:

Adds the same shellcheck action as we have it in pihole/pihole and puts all CI workflows in a single file


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team as a code owner August 4, 2025 19:14
@yubiuser yubiuser changed the title Add ShellCheck Add ShellCheck and unify CI workflows Aug 4, 2025
@yubiuser yubiuser mentioned this pull request Aug 4, 2025
Copy link

github-actions bot commented Aug 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Aug 5, 2025

Conflicts have been resolved.

1 similar comment
Copy link

github-actions bot commented Aug 5, 2025

Conflicts have been resolved.

@yubiuser yubiuser requested a review from Copilot August 5, 2025 07:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds ShellCheck static analysis and consolidates all CI workflows into a single file for better maintainability. The changes address ShellCheck warnings by improving shell script best practices throughout the codebase.

  • Adds ShellCheck configuration and integrates it into CI workflows
  • Consolidates separate CI workflow files into a unified CI.yml file
  • Updates shell script to follow ShellCheck recommendations for variable quoting and comparison operators

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
padd.sh Updated variable quoting and comparison operators to follow ShellCheck best practices
.shellcheckrc Added ShellCheck configuration with custom rules and disabled checks
.github/workflows/CI.yml New unified CI workflow combining shellcheck, codespell, and editorconfig checks
.github/workflows/editorconfig-checker.yml Removed standalone editorconfig workflow (consolidated into CI.yml)
.github/workflows/codespell.yml Removed standalone codespell workflow (consolidated into CI.yml)

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Copy link

Conflicts have been resolved.

@yubiuser yubiuser requested a review from PromoFaux October 4, 2025 22:19
@yubiuser yubiuser merged commit 7484216 into development Oct 5, 2025
3 checks passed
@yubiuser yubiuser deleted the shellcheck branch October 5, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants