-
-
Notifications
You must be signed in to change notification settings - Fork 129
Add ShellCheck and unify CI workflows #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
1 similar comment
Conflicts have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds ShellCheck static analysis and consolidates all CI workflows into a single file for better maintainability. The changes address ShellCheck warnings by improving shell script best practices throughout the codebase.
- Adds ShellCheck configuration and integrates it into CI workflows
- Consolidates separate CI workflow files into a unified CI.yml file
- Updates shell script to follow ShellCheck recommendations for variable quoting and comparison operators
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
padd.sh | Updated variable quoting and comparison operators to follow ShellCheck best practices |
.shellcheckrc | Added ShellCheck configuration with custom rules and disabled checks |
.github/workflows/CI.yml | New unified CI workflow combining shellcheck, codespell, and editorconfig checks |
.github/workflows/editorconfig-checker.yml | Removed standalone editorconfig workflow (consolidated into CI.yml) |
.github/workflows/codespell.yml | Removed standalone codespell workflow (consolidated into CI.yml) |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Conflicts have been resolved. |
What does this PR aim to accomplish?:
Adds the same
shellcheck
action as we have it inpihole/pihole
and puts all CI workflows in a single fileBy submitting this pull request, I confirm the following:
git rebase
)