Skip to content

Add welcome bot #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2025
Merged

Add welcome bot #11

merged 3 commits into from
Jul 11, 2025

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Jul 9, 2025 •
edited
Loading

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@github-actions github-actions bot added Documentation This issue or PR is about the documentation Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog labels Jul 9, 2025
@RayStick RayStick mentioned this pull request Jul 9, 2025
Open
10 tasks
@RayStick RayStick marked this pull request as ready for review July 9, 2025 14:37
me-pic
me-pic reviewed Jul 10, 2025
View reviewed changes
.github/config.yml Outdated
![Thank You Banner](https://raw.githubusercontent.com/physiopy/physiopy-test-workflows/master/welcome_banner.png)
🎉 Congrats on merging your first pull request in this repo! We appreciate your contribution to the Physiopy community!
:eyes: Please check that your contribution is correctly reported in the repo's README and on Physiopy's website! No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the hyperlink to the Physiopy website home page ?
https://physiopy.github.io/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See add link

README.md
<img alt="repository" src="https://raw.githubusercontent.com/physiopy/phys2bids/master/docs/_static/physiopy_logo_small.png" height="150">

This repository contains the source files for our community guidelines.
This repository contains the source files for our community guidelines on collecting physiological data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the guideline also has a section on data processing, maybe we can add :
This repository contains the source files for our community guidelines on collecting and processing physiological data.
If I'm remembering correctly, we also talked at some point that it would be relevant to add a section on Data QCing. So I'm wondering if that specification is necessary, or if it's better to simply modify the README every time a new section is added 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I see what you mean. Shall we keep it general (i.e. unchanged) then?
I think "collecting and processing physiological data" covers a lot though =D so maybe this is good

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree ! Let's keep it general.

@RayStick RayStick merged commit fb9f523 into master Jul 11, 2025
2 checks passed
@RayStick RayStick deleted the add-welcome-bot branch July 11, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-pic me-pic me-pic left review comments

Assignees

@RayStick RayStick

Labels

Documentation This issue or PR is about the documentation Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RayStick @me-pic