Configure PromoteParameterRule for issue-bot #4392
Open
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm thinking again.. maybe we should just enable the optional rules in issue bot..? or maybe even just enable bleeding edge? |
|
.. hmm reflecting the playground settings 1:1 seems to be the most intuive fix, which is also reasonable for the end-user (least suprising) |
|
This pull request has been marked as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue-bot currently misses these errors/fixes, see #4381 (comment)
1:1 copy of the config from https://github.com/phpstan/phpstan/blob/2.1.x/playground-runner/playground.neon