Skip to content

random: Fix memory leak when serialization fails #20383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

random: Fix memory leak when serialization fails #20383

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e08c40
random: Fix memory leak when serialization fails
ndossche Nov 3, 2025
a063178
Update ext/random/engine_mt19937.c
ndossche Nov 3, 2025
2b70bb4
remove dupe
ndossche Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/random/engine_mt19937.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ PHP_METHOD(Random_Engine_Mt19937, __serialize)
/* state */
array_init(&t);
if (!engine->algo->serialize(engine->status, Z_ARRVAL(t))) {
zval_ptr_dtor_nogc(&t);
zend_throw_exception(NULL, "Engine serialize failed", 0);
RETURN_THROWS();
}
Expand Down
Loading