Use zend_string_release_ex() in concat_function() #18827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strings we encounter are either interned in which case the persistent bool doesn't matter; or they're temporary as the code already assumes that anyway. This patch shrinks the function from 3332 bytes to 3173 bytes on x86-64 with GCC 15.1.1.
Girgias
approved these changes
Jun 12, 2025
|
do I assume right, that reduction in code-size of or does this PR targets a different goal? |
|
This could have a theoretical performance impact if your application does a lot of concats and suffers from instruction cache pressure. Most apps don't though. Still it's nice to clean up machine code bloat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strings we encounter are either interned in which case the persistent bool doesn't matter; or they're temporary as the code already assumes that anyway.
This patch shrinks the function from 3332 bytes to 3173 bytes on x86-64 with GCC 15.1.1.