Update ext/random/engine_mt19937.c

ndossche · TimWolla · web-flow · commit a063178255cf · 2025-11-03T22:41:43.000+01:00
Co-authored-by: Tim Düsterhus &lt;timwolla@googlemail.com&gt;
diff --git a/ext/random/engine_mt19937.c b/ext/random/engine_mt19937.c
@@ -329,8 +329,8 @@ PHP_METHOD(Random_Engine_Mt19937, __serialize)
 
 	/* state */
 	array_init(&t);
+	zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &t);
 	if (!engine->algo->serialize(engine->status, Z_ARRVAL(t))) {
-		zval_ptr_dtor_nogc(&t);
 		zend_throw_exception(NULL, "Engine serialize failed", 0);
 		RETURN_THROWS();
 	}

Original file line number	Diff line number	Diff line change
`@@ -329,8 +329,8 @@ PHP_METHOD(Random_Engine_Mt19937, __serialize)`
`329`	`329`
`330`	`330`	`/* state */`
`331`	`331`	`array_init(&t);`
	`332`	`+ zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &t);`
`332`	`333`	`if (!engine->algo->serialize(engine->status, Z_ARRVAL(t))) {`
`333`		`- zval_ptr_dtor_nogc(&t);`
`334`	`334`	`zend_throw_exception(NULL, "Engine serialize failed", 0);`
`335`	`335`	`RETURN_THROWS();`
`336`	`336`	`}`