random: Fix memory leak when serialization fails

ndossche · ndossche · commit 5e08c400100f · 2025-11-03T22:32:39.000+01:00
diff --git a/ext/random/engine_mt19937.c b/ext/random/engine_mt19937.c
@@ -330,6 +330,7 @@ PHP_METHOD(Random_Engine_Mt19937, __serialize)
 	/* state */
 	array_init(&t);
 	if (!engine->algo->serialize(engine->status, Z_ARRVAL(t))) {
+		zval_ptr_dtor_nogc(&t);
 		zend_throw_exception(NULL, "Engine serialize failed", 0);
 		RETURN_THROWS();
 	}

Original file line number	Diff line number	Diff line change
`@@ -330,6 +330,7 @@ PHP_METHOD(Random_Engine_Mt19937, __serialize)`
`330`	`330`	`/* state */`
`331`	`331`	`array_init(&t);`
`332`	`332`	`if (!engine->algo->serialize(engine->status, Z_ARRVAL(t))) {`
	`333`	`+ zval_ptr_dtor_nogc(&t);`
`333`	`334`	`zend_throw_exception(NULL, "Engine serialize failed", 0);`
`334`	`335`	`RETURN_THROWS();`
`335`	`336`	`}`