Skip to content

Conversation

gsteel
Copy link
Contributor

@gsteel gsteel commented Oct 30, 2024

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Adds PHP 8.4 to the test matrix, explicitly marks nullable parameters as nullable.

Why?

Implicit nulls are deprecated on 8.4

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! looks good, i will merge and tag a release.

@dbu dbu merged commit f3eb48d into php-http:2.x Oct 31, 2024
8 checks passed
@gsteel gsteel deleted the php-8.4 branch October 31, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants