Skip to content

Conversation

Chris53897
Copy link
Contributor

#242

Just a quick view and open for disussion what to do next.
Needs rebasing after the other 2 PRs are merged.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • [] Documentation pull request created (if not simply a bugfix)

To Do

  • to Discuss

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

the failing tests (apart from the stream_for issue) are probably also about missing mocking that is now detected because of strict typing of 3rd party libraries. do you look into those?

drop support for symfony < 5.4,
drop support for symfony < 5.4,
drop support for symfony < 5.4,
drop support for symfony < 5.4,
@nunoplopes
Copy link

ping, could this be revived? It would be great to remove those unneeded dependencies for PHP 8.
@Chris53897 do you have time to rebase this?

@Chris53897
Copy link
Contributor Author

I resolved the conflicts. But there are errors. Maybe i have time at end of march to have a deeper look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants