Skip to content

Remove SQLite specific code #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from
Draft

Remove SQLite specific code #55

wants to merge 1 commit into from

Conversation

settermjd
Copy link
Collaborator

@settermjd settermjd commented May 28, 2025 •
edited
Loading

This PR removes all of the SQLite-specific files as they're being moved to an SQLite-specific package: laminas-db-adapter-sqlite https://github.com/axleus/laminas-db-adapter-sqlite.

@settermjd
Remove SQLite-specific files from the project
ba1fe1a 
These are being moved to a new, SQLite-specific, package
laminas-db-adapter-sqlite, so are being removed from this one.
@settermjd settermjd requested review from tyrsson and simon-mundy May 28, 2025 11:25
@settermjd settermjd self-assigned this May 28, 2025
@settermjd settermjd added the enhancement New feature or request label May 28, 2025
tyrsson
tyrsson approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@tyrsson tyrsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Question.

Until the satellite packages are complete do we want to create these PR's and leave them unmerged so that we maintain the original context as it stands until all testing is good in the satellite? If we confine these PR's strictly to file removal they should not create conflicts.

On the other hand, if we merge them now they should also not create conflicts. That I can think of off the top of my head....

@github-project-automation github-project-automation bot moved this from Todo to In Progress in @laminas-db May 29, 2025
@settermjd
Copy link
Collaborator Author

Approved.

Question.

Until the satellite packages are complete do we want to create these PR's and leave them unmerged so that we maintain the original context as it stands until all testing is good in the satellite? If we confine these PR's strictly to file removal they should not create conflicts.

On the other hand, if we merge them now they should also not create conflicts. That I can think of off the top of my head....

Fair point. I'll change the PR to a draft one until the respective PR (from Simon) is reviewed and merged.

@settermjd settermjd marked this pull request as draft May 29, 2025 19:56
@settermjd
Copy link
Collaborator Author

Approved.

Question.

Until the satellite packages are complete do we want to create these PR's and leave them unmerged so that we maintain the original context as it stands until all testing is good in the satellite? If we confine these PR's strictly to file removal they should not create conflicts.

On the other hand, if we merge them now they should also not create conflicts. That I can think of off the top of my head....

Unmerged makes most sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrsson tyrsson tyrsson approved these changes

@simon-mundy simon-mundy Awaiting requested review from simon-mundy

Assignees

@settermjd settermjd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@settermjd @tyrsson