Refactor sql abstraction #46
Conversation
simon-mundy
added
enhancement
…tion # Conflicts: # test/integration/Platform/MysqlFixtureLoader.php # test/unit/Sql/Predicate/NotBetweenTest.php # test/unit/Sql/SelectTest.php # test/unit/TableGateway/Feature/MasterSlaveFeatureTest.php
| @@ -61,7 +62,7 @@ public function __construct( | |||
|
|
|||
| if (is_array($driver)) { | |||
| $parameters = $driver; | |||
| if ($profiler === null && isset($parameters['profiler'])) { | |||
| if (!$profiler instanceof \Laminas\Db\Adapter\Profiler\ProfilerInterface && isset($parameters['profiler'])) { | |||
There was a problem hiding this comment.
Is this not a violation of the coding standard?
There was a problem hiding this comment.
Also... this is being rewritten anyway isn't it?
There was a problem hiding this comment.
Yes, so its going to be a conflict that needs resolved either way.
The coding standard requires use statements vs fully qualified paths iirc. I'm pretty sure that was a Rector change which is the only reason I was pointing it out.
| */ | ||
| public function getLastGeneratedValue($name = null) | ||
| #[Override] public function getLastGeneratedValue($name = null): string|null |
There was a problem hiding this comment.
Didn't we have a discussion last week or so about nullable return types being, for example, ?string.
| @@ -250,7 +243,7 @@ private function createErrorHandler() | |||
| * @throws ErrorException if error is not within the error_reporting mask. | |||
| */ | |||
| return function ($errno, $errstr, $errfile, $errline) { | |||
| if (! (error_reporting() & $errno)) { | |||
| if ((error_reporting() & $errno) === 0) { | |||
There was a problem hiding this comment.
Could a constant be used here, instead of 0?
| ) { | ||
| $this->isBuffered = true; | ||
| } | ||
| } elseif ($resource instanceof mysqli || $resource instanceof mysqli_result |
There was a problem hiding this comment.
Would it be worth splitting the conditions across multiple lines so that they're that much easier to read?
This is a major update to the Laminas\Db\Sql components, working specifically on the following refactoring:-
The new ExpressionPart allows a string specification (e.g. %s LIKE %s) as well as storing Argument values. This new storage container makes typing these values more robust and more flexible.
The ExpressionData container takes 1 or more ExpressionPart components and generates a space-delimited SQL string as required.
NOTE: Please ignore
Rectorfiles, the Rector requirement in composer.json and the temporary change in PHP to 8.3 - this is only for the convenience of using dev tools and will be reverted back to 8.1 in due course.