Migrate the SQLite code from the main laminas-db repo to this one #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates PHPUnit's configuration file to match the project, and adds config files for PHP Code_Sniffer and Psalm.
These changes, while by no means complete, are a start along the way to cleaning up the codebase so that it is as simple as possible to perform static analysis on.
tyrsson
previously approved these changes
Jun 2, 2025
This change, similar to previous ones, contains a series of changes designed to improve the quality of static analysis with Psalm (and code readability and maintainability). I don't believe that there are, effectively, any actual code changes.
This change resets Psalm's baseline, and updates its configuration to ignore a series of rules that are, currently, not required, as they're making the transition more challenging. Specifically, they can be ignored for the time being while the code is cleaned up, after which they'll be reinstated.
This adds Psalm to the QA job, so that it's included in that task, ensuring that the code is as maintainable as possible.
|
Sorry about the sheer number of files in this PR. |
Would love to discuss this fully. |
|
I'm happy too anytime we're both online. |
tyrsson
reviewed
Jun 21, 2025
| $pdoDriver = substr($pdoDriver, 3) ?: ''; | ||
| } | ||
| break; | ||
| case 'pdodriver': |
There was a problem hiding this comment.
I missed this in my initial review. I think it would serve us well to remove the one off parameters in favor of using just the 'driver' key. One of my goals is to standardize this to ease documenting all of the changes. I can not confirm this but my hunch is that we find these one offs due to so many different contributors providing code over the years.
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes @simon-mundy's core work, and some extra clean up after running the QA tools on the code base.