Adds unit test for Pre/PostCommandHandlerMiddleware(s) #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joey Smith <[email protected]> Signed-off-by: Joey Smith <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit test coverage for the PreCommandHandlerMiddleware and PostCommandHandlerMiddleware classes, ensuring proper functionality of these middleware components in the command bus system.
- Adds test coverage for PreCommandHandlerMiddleware behavior including command delegation and result handling
- Adds test coverage for PostCommandHandlerMiddleware behavior including CommandResult unwrapping and regular command processing
- Ensures both middleware classes implement the MiddlewareInterface correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/unit/Middleware/PreCommandHandlerMiddlewareTest.php | Comprehensive test suite for PreCommandHandlerMiddleware covering command delegation, result handling, and interface compliance |
| test/unit/Middleware/PostCommandHandlerMiddlewareTest.php | Comprehensive test suite for PostCommandHandlerMiddleware covering CommandResult unwrapping, status handling, and regular command processing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.