Justfile and CI changes #701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timokoesters
force-pushed
the
timo/justfile
branch
from
6c1b02a to
a2642fb
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
857c9c1 to
afe6086
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
1ab489a to
89467d0
Compare
timokoesters
force-pushed
the
timo/justfile
branch
5 times, most recently
from
a5b884e to
0a61855
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
9a54fe3 to
261e3bf
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
eb844df to
2058913
Compare
timokoesters
force-pushed
the
timo/justfile
branch
3 times, most recently
from
68a3a68 to
f51d646
Compare
timokoesters
force-pushed
the
timo/justfile
branch
2 times, most recently
from
cd18fe9 to
06eeff5
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
06eeff5 to
383e3f1
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
383e3f1 to
20a4bd6
Compare
timokoesters
force-pushed
the
timo/justfile
branch
2 times, most recently
from
7b01427 to
3e464b3
Compare
timokoesters
force-pushed
the
timo/justfile
branch
from
3e464b3 to
1eec13e
Compare
timokoesters
commented
Oct 1, 2025
| - name: Set up Rust toolchain | ||
| uses: dtolnay/[email protected] | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo build --verbose |
There was a problem hiding this comment.
I removed cargo build, because everything it does should be covered by other tests.
| CODE_SIGN_STYLE = Automatic; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| DEVELOPMENT_TEAM = 7QXP938FNA; | ||
| DEVELOPMENT_TEAM = ""; |
There was a problem hiding this comment.
I removed the signing key from debug builds. I hope that CI builds are still signed correctly.
| # | ||
| # SPDX-License-Identifier: AGPL-3.0-or-later | ||
|
|
||
| DATABASE_URL=sqlite:coreclient/client.db |
There was a problem hiding this comment.
I checked in this file, because my IDE needs this. I think it's useful to have this as the default.
| cargo sqlx prepare --database-url sqlite://{{justfile_directory()}}/coreclient/client.db | ||
|
|
||
| # This task will run the command and hide stdout. If git diff then reports unstaged changes, the task will fail. | ||
| _check-unstaged-changes command: |
There was a problem hiding this comment.
I like to disable stdout, so it's cleaner when used as a CLI. I can enable all logs in CI if we want.
kkohbrok
approved these changes
Oct 1, 2025
|
One of the TODOs is still marked as not done, has that been addressed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
$ justwill list all commands$ just cifor all checks and tests or others like$ just check-rust,$ just testor even$ just test-flutter$ just run-clientand$ just run-client-cached$ just run-server$ just regeneratefor frb, l10n and sqlxI don't know how I can test these: